-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Json output for delete/list + better ABS error handling #86
Conversation
17c0085
to
71628b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of notes of feedback!
71628b8
to
a3647d6
Compare
This commit adds an option `--json` to the list and delete commands. When the json flag is used the commands will print output as formatted JSON rather than pretty printed strings.
When ABS returns an http status code other than 200 or 202, the ABS code should fail
a3647d6
to
1eaa807
Compare
@briancain updated :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. I can't these these against this pooler, so if someone wanted to do that, that would be great :)
Status
[Ready for Merge]
Description
Updates to the list and delete commands to include a
--json
option so those commands can be used with scripts and automation that require structured output.Additionally, add better error handling of status codes from ABS
Related Issues
Todos
Reviewers
@puppetlabs/dio
@highb
@briancain